Changelog
- 2020-08-07: Initial Draft
- 2020-09-01: Further clarify rules
Status
ProposedAbstract
Fully deterministic structure serialization, which works across many languages and clients, is needed when signing messages. We need to be sure that whenever we serialize a data structure, no matter in which supported language, the raw bytes will stay the same. Protobuf serialization is not bijective (i.e. there exist a practically unlimited number of valid binary representations for a given protobuf document)1. This document describes a deterministic serialization scheme for a subset of protobuf documents, that covers this use case but can be reused in other cases as well.Context
For signature verification in Cosmos SDK, the signer and verifier need to agree on the same serialization of aSignDoc
as defined in
ADR-020 without transmitting the
serialization.
Currently, for block signatures we are using a workaround: we create a new TxRaw
instance (as defined in adr-020-protobuf-transaction-encoding)
by converting all Tx
fields to bytes on the client side. This adds an additional manual
step when sending and signing transactions.
Decision
The following encoding scheme is to be used by other ADRs, and in particular forSignDoc
serialization.
Specification
Scope
This ADR defines a protobuf3 serializer. The output is a valid protobuf serialization, such that every protobuf parser can parse it. No maps are supported in version 1 due to the complexity of defining a deterministic serialization. This might change in future. Implementations must reject documents containing maps as invalid input.Background - Protobuf3 Encoding
Most numeric types in protobuf3 are encoded as varints. Varints are at most 10 bytes, and since each varint byte has 7 bits of data, varints are a representation ofuint70
(70-bit unsigned integer). When
encoding, numeric values are casted from their base type to uint70
, and when
decoding, the parsed uint70
is casted to the appropriate numeric type.
The maximum valid value for a varint that complies with protobuf3 is
FF FF FF FF FF FF FF FF FF 7F
(i.e. 2**70 -1
). If the field type is
{,u,s}int64
, the highest 6 bits of the 70 are dropped during decoding,
introducing 6 bits of malleability. If the field type is {,u,s}int32
, the
highest 38 bits of the 70 are dropped during decoding, introducing 38 bits of
malleability.
Among other sources of non-determinism, this ADR eliminates the possibility of
encoding malleability.
Serialization rules
The serialization is based on the protobuf3 encoding with the following additions:- Fields must be serialized only once in ascending order
- Extra fields or any extra data must not be added
- Default values must be omitted
repeated
fields of scalar numeric types must use packed encoding- Varint encoding must not be longer than needed:
- No trailing zero bytes (in little endian, i.e. no leading zeroes in big
endian). Per rule 3 above, the default value of
0
must be omitted, so this rule does not apply in such cases. - The maximum value for a varint must be
FF FF FF FF FF FF FF FF FF 01
. In other words, when decoded, the highest 6 bits of the 70-bit unsigned integer must be0
. (10-byte varints are 10 groups of 7 bits, i.e. 70 bits, of which only the lowest 70-6=64 are useful.) - The maximum value for 32-bit values in varint encoding must be
FF FF FF FF 0F
with one exception (below). In other words, when decoded, the highest 38 bits of the 70-bit unsigned integer must be0
.- The one exception to the above is negative
int32
, which must be encoded using the full 10 bytes for sign extension2.
- The one exception to the above is negative
- The maximum value for Boolean values in varint encoding must be
01
(i.e. it must be0
or1
). Per rule 3 above, the default value of0
must be omitted, so if a Boolean is included it must have a value of1
.
- No trailing zero bytes (in little endian, i.e. no leading zeroes in big
endian). Per rule 3 above, the default value of
""
, 0
), null
or undefined, leading to 3
different documents.
Omitting fields set to default values is valid because the parser must assign
the default value to fields missing in the serialization4. For scalar
types, omitting defaults is required by the spec5. For repeated
fields, not serializing them is the only way to express empty lists. Enums must
have a first element of numeric value 0, which is the default6. And
message fields default to unset7.
Omitting defaults allows for some amount of forward compatibility: users of
newer versions of a protobuf schema produce the same serialization as users of
older versions as long as newly added fields are not used (i.e. set to their
default value).
Implementation
There are three main implementation strategies, ordered from the least to the most custom development:-
Use a protobuf serializer that follows the above rules by default. E.g.
gogoproto is known to
be compliant by in most cases, but not when certain annotations such as
nullable = false
are used. It might also be an option to configure an existing serializer accordingly. -
Normalize default values before encoding them. If your serializer follows
rule 1. and 2. and allows you to explicitly unset fields for serialization,
you can normalize default values to unset. This can be done when working with
protobuf.js:
-
Use a hand-written serializer for the types you need. If none of the above
ways works for you, you can write a serializer yourself. For SignDoc this
would look something like this in Go, building on existing protobuf utilities:
Test vectors
Given the protobuf definitionArticle.proto
Consequences
Having such an encoding available allows us to get deterministic serialization for all protobuf documents we need in the context of Cosmos SDK signing.Positive
- Well defined rules that can be verified independent of a reference implementation
- Simple enough to keep the barrier to implement transaction signing low
- It allows us to continue to use 0 and other empty values in SignDoc, avoiding the need to work around 0 sequences. This does not imply the change from Link should not be merged, but not too important anymore.
Negative
- When implementing transaction signing, the encoding rules above must be understood and implemented.
- The need for rule number 3. adds some complexity to implementations.
- Some data structures may require custom code for serialization. Thus the code is not very portable - it will require additional work for each client implementing serialization to properly handle custom data structures.
Neutral
Usage in Cosmos SDK
For the reasons mentioned above (“Negative” section) we prefer to keep workarounds for shared data structure. Example: the aforementionedTxRaw
is using raw bytes
as a workaround. This allows them to use any valid Protobuf library without
the need of implementing a custom serializer that adheres to this standard (and related risks of bugs).
References
- 1 When a message is serialized, there is no guaranteed order for how its known or unknown fields should be written. Serialization order is an implementation detail and the details of any particular implementation may change in the future. Therefore, protocol buffer parsers must be able to parse fields in any order. from Link
- 2 Link
- 3 Note that for scalar message fields, once a message is parsed there’s no way of telling whether a field was explicitly set to the default value (for example whether a boolean was set to false) or just not set at all: you should bear this in mind when defining your message types. For example, don’t have a boolean that switches on some behavior when set to false if you don’t want that behavior to also happen by default. from Link
- 4 When a message is parsed, if the encoded message does not contain a particular singular element, the corresponding field in the parsed object is set to the default value for that field. from Link
- 5 Also note that if a scalar message field is set to its default, the value will not be serialized on the wire. from Link
- 6 For enums, the default value is the first defined enum value, which must be 0. from Link
- 7 For message fields, the field is not set. Its exact value is language-dependent. from Link
- Encoding rules and parts of the reasoning taken from canonical-proto3 Aaron Craelius